On Wed, Jun 24, 2020 at 09:25:37AM +0200, Christoph Hellwig wrote: > On Mon, Jun 22, 2020 at 06:53:23PM +0530, Chandan Babu R wrote: > > On Monday 22 June 2020 6:21:37 PM IST Chandan Babu R wrote: > > > On Saturday 20 June 2020 12:40:59 PM IST Christoph Hellwig wrote: > > > > In preparation of removing the historic icinode struct, move the flags2 > > > > field into the containing xfs_inode structure. > > > > > > > > > > The changes look good to me. > > > > > > Reviewed-by: Chandan Babu R <chandanrlinux@xxxxxxxxx> > > > > The commit "fs/xfs: Update xfs_ioctl_setattr_dax_invalidate()" > > (e4f9ba20d3b8c2b86ec71f326882e1a3c4e47953) adds the function > > xfs_ioctl_setattr_prepare_dax() which refers to xfs_icdinode->di_flags2. A > > rebase should solve this issue. > > That doesn't exist in xfs/for-next yet. Darrick, do you want me to > rebase on top of Linus' tree? Sure? I haven't really started working on 5.8 fixes branches yet, but I'll fast-forward for-next up to 5.8-rc1. --D