On Sat, Jun 20, 2020 at 03:10:05AM +0100, peter green wrote: > Putting the debian bug back in cc, previous mails are visible at https://marc.info/?l=linux-xfs&m=159253950420613&w=2 > > On 19/06/2020 23:43, Dave Chinner wrote: > > > Isn't the configure script supposed to handle install locations? > > Both xfsprogs and xfsdump have this in their include/builddefs.in: > > > > PKG_ROOT_SBIN_DIR = @root_sbindir@ > > PKG_ROOT_LIB_DIR= @root_libdir@@libdirsuffix@ > > > > So the actual install locations are coming from the autoconf setup > > the build runs under. Looking in configure.ac in xfsprogs and > > xfsdump, they both do the same thing: > > > The issue is that xfsdump installs the programs in /sbin but it *also* creates symlinks in /usr/sbin, > presumablly at some point the binaries were moved to /sbin but the developers wanted to keep > packages that hardcoded the paths working. Ah, thanks for explaining the issue, Peter. > Those symlinks are suppressed if installing directly to a merged-usr system, which is fine for > end-users installing the program directly but isn't useful if installing to a destination dir for > packaing purposed. OK, so what I'm really missing here is knowledge on how a modern distro is expecting binaries to be packaged. If every distro is having to work around the install locations the package uses by default, then we need to fix up the default locations and behaviour of the upstream packaging. So, what is expected behaviour in these situations: - user installs directly in /usr/local/... or $HOME/... - user installs directly in /usr/.... - package installed on split-usr system - package installed on merged-usr system Th first two here are coded into the build via 'make install', and the package build systems use the same install command to build the package. It seems to me that we'd want 'make install' to behave the same way for the last 3 cases, but I'm missing how the build/packaging system is actually supposed to reliably detect the differences between such split/merged systems and hence just DTRT.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
