Re: [PATCH 1/7] xfs: Fix log reservation calculation for xattr insert operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 19 June 2020 8:03:54 PM IST Christoph Hellwig wrote:
> On Sat, Jun 06, 2020 at 01:57:39PM +0530, Chandan Babu R wrote:
> > -		tres.tr_logres = M_RES(mp)->tr_attrsetm.tr_logres +
> > -				 M_RES(mp)->tr_attrsetrt.tr_logres *
> > -					args->total;
> > -		tres.tr_logcount = XFS_ATTRSET_LOG_COUNT;
> > -		tres.tr_logflags = XFS_TRANS_PERM_LOG_RES;
> > +		tres = M_RES(mp)->tr_attrset;
> >  		total = args->total;
> 
> tres can become a pointer now, and we can avoid the struct copy.
> 

Yes, you are right. I will fix this up. Thanks for the review.

-- 
chandan






[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux