On Fri, Jun 19, 2020 at 07:36:08AM -0700, Christoph Hellwig wrote: > I'm lost in 4 layers of full quotes. Can someone summarize the > discussion without hundreds of lines of irrelevant quotes? Naming issues with helper functions, and pointing out that any code path that thinks it could add $nr extents to a file needs to check for overflows in (ifp->if_nextents + $nr) after we take the ILOCK but before we dirty the transaction. --D