On Tue, Jun 02, 2020 at 05:36:56PM -0700, Darrick J. Wong wrote: > On Sun, May 24, 2020 at 11:17:56AM +0200, Christoph Hellwig wrote: > > In preparation of removing the historic icinode struct, move the > > dmevmask field into the containing xfs_inode structure. > > Do we even use dmevmask or dmstate? Why not just get rid of them and > set them to zero ondisk? "we" don't really use it, no. But until recently we had an ioctl to set it, and bulkstat can report it. If we didn't have the fields in xfs_inode we'd thus lose information when changing the inode. OTOH once Daves series to always read the inode buffer when dirting the inode is merged we could copy it straight from the buffer to the log inode. I'll volunteer to do that work once all the reuquired bit are merged, but for now I'd just like to kill off the horrible icdinode structure.
