Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
From: Bob Peterson <rpeterso@xxxxxxxxxx>
Date: Tue, 16 Jun 2020 12:38:38 -0400 (EDT)
Cc: Andreas Gruenbacher <agruenba@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
In-reply-to: <20200616162539.GN11245@magnolia>
References: <20200615160244.741244-1-agruenba@redhat.com> <20200615233239.GY2040@dread.disaster.area> <20200615234437.GX8681@bombadil.infradead.org> <20200616003903.GC2005@dread.disaster.area> <315900873.34076732.1592309848873.JavaMail.zimbra@redhat.com> <20200616132318.GZ8681@bombadil.infradead.org> <CAHc6FU7uU8rUMdkspqH+Zv_O5zi2eEyOYF4x4Je-eCNeM+7NHA@mail.gmail.com> <20200616162539.GN11245@magnolia>

----- Original Message -----
> So... you found this through code inspection, and not because you
> actually hit this on gfs2, or any of the other iomap users?
> 
> I generally think this looks ok, but I want to know if I should be
> looking deeper. :)
> 
> --D

Correct. Code-inspection only. I never actually hit the problem.
If those errors are really so unusual and catastrophic, perhaps
we should just change them to BUG_ONs or something instead.
Why bother unlocking if we're already 1.9 meters underground?

Bob Peterson

Follow-Ups:
- Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
  - From: Dave Chinner

References:
- [PATCH] iomap: Make sure iomap_end is called after iomap_begin
  - From: Andreas Gruenbacher
- Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
  - From: Dave Chinner
- Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
  - From: Matthew Wilcox
- Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
  - From: Dave Chinner
- Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
  - From: Bob Peterson
- Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
  - From: Matthew Wilcox
- Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
  - From: Andreas Gruenbacher
- Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
  - From: Darrick J. Wong

Prev by Date: Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
Next by Date: Re: [RFC PATCH v3] xfs_repair: fix rebuilding btree block less than minrecs
Previous by thread: Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
Next by thread: Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]