Re: [PATCH 00/14] xfs: widen timestamps to deal with y2038

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 31, 2020 at 08:31:54PM +0300, Amir Goldstein wrote:
> > > I plan to rebase the whole series after 5.8-rc1, but if you'd like to
> > > look at the higher level details (particularly in the quota code, which
> > > is a bit murky) sooner than later, I don't mind emailing out what I have
> > > now.
> > >
> >
> > No need. I can look at high level details on your branch.
> > Will hold off review comments until rebase unless I find something
> > that calls for your attention.
> >
> 
> I went over the code in:
> a7091aa0d632 xfs: enable big timestamps
> 
> I did not find any correctness issues.
> I commented on what seems to me like a trap for future bugs
> with how the incore timestamps are converted.
> 
> So besides "widen ondisk timestamps" and "enable bigtime for quota timers",
> feel free to add:
> Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>
> 
> For patches that do not change on rebase.

Ok, thanks for the first round of review!  See you after -rc1. :)

--D

> Thanks,
> Amir.



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux