On Sat, May 23, 2020 at 07:25:55PM -0700, Darrick J. Wong wrote: > Please always cc linux-xfs when you're changing fs/xfs code. > > *Especially* when it involves changes to ondisk structures. I can't find this patch in lkml or -fsdevel on lore.kernel.org, so I have no idea where this patch even came from. Which means I can't even check what the structure change is because it wasn't quoted in full. So, NACK on this until the entire patch is resent to linux-xfs and run through all the shutdown and error recovery tests in fstests.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx