On Wed, May 20, 2020 at 11:36:27AM -0700, Darrick J. Wong wrote: > > > - if (flags & SYNC_WAIT) > > > + if (wait) > > > ret = -EAGAIN; > > > return ret; > > > > Just me, but I'd prefer an explicit: > > > > if (wait) > > return -EAGAIN; > > return 0; > > > > here. Not really new in this patch, but if you touch this area anyway.. > > How about 'return wait ? -EAGAIN : 0;' ? Yikes. Why does everyone hate the nice, explicit and readable if statements?
