On Mon, May 18, 2020 at 05:52:17PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > el_gets returns NULL if it fails to read any characters (due to EOF or > errors occurred). strdup will crash if it is fed a NULL string, so > check the return value to avoid segfaulting. Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> And I'm pretty sure I've reviewed this before..