On Tue, May 19, 2020 at 11:57:43PM -0700, Christoph Hellwig wrote: > Shouldn't m_errortag and m_errortag_kobj also go into the read-mostly > section? > > Otherwise looks good: kobjs are reference counted and full of random stuff like lists, sysfs references, etc, so they aren't obviously read-mostly variables. I left all the kobjs in the write section for this reason. The errortag stuff is also debug only code so I didn't so I didn't bother touching it. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx