On 5/19/20 2:03 AM, Donald Douwsma wrote:
>
> On 19/05/2020 11:29, Eric Sandeen wrote:
>> The Fixes: commit tried to avoid a segfault in case the progress timer
>> went off before the first message type had been set up, but this
>> had the net effect of short-circuiting the pthread start routine,
>> and so the timer didn't get set up at all and we lost all fine-grained
>> progress reporting.
>>
>> The initial problem occurred when log zeroing took more time than the
>> timer interval.
>>
>> So, make a new log zeroing progress item and initialize it when we first
>> set up the timer thread, to be sure that if the timer goes off while we
>> are still zeroing the log, it will be initialized and correct.
>>
>> (We can't offer fine-grained status on log zeroing, so it'll go from
>> zero to $LOGBLOCKS with nothing in between, but it's unlikely that log
>> zeroing will take so long that this really matters.)
>>
>> Reported-by: Leonardo Vaz <lvaz@xxxxxxxxxx>
>> Fixes: 7f2d6b811755 ("xfs_repair: avoid segfault if reporting progre...")
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>> ---
> I've been looking at this myself, got stuck writing an xfstest, which this
> passes, though the fix I was trying missed at least one of the formatters
> that this fixes, and the log zeroing is a nice touch.
>
> Reviewed-by: Donald Douwsma <ddouwsma@xxxxxxxxxx>
Hm, serves you right for writing a validation test. ;) sorry :(
But: "the fix I was trying missed at least one of the formatters
that this fixes" - which one is that? I didn't think I fixed any existing
thing.
-Eric
