On Sat, May 16, 2020 at 08:16:58PM +0200, Christoph Hellwig wrote: > On Sat, May 16, 2020 at 11:01:50AM -0700, Darrick J. Wong wrote: > > > In my case it was the xfs_scrub run after generic/001 that did it. > > > > > > I think we're covered against null *ifp in most cases because they're > > > guarded by an if(XFS_IFORK_Q()); it's jut here where I went around > > > shortcutting. Maybe I should just fix this function for you... :) > > > > Hmm, that sounded meaner than I intended it to be. :/ > > > > Also, it turns out that it's pretty easy to fix this as part of fixing > > the contorted logic in patch 1 (aka xchk_bmap_check_rmaps) so I'll do > > that there. > > How about you send a patch to just fix up that function for now, > and I'll rebase on top of that? Ok. --D
