On 5/9/20 12:01 PM, Christoph Hellwig wrote: > Hi Eric, > > this series contains the differences to my port that seem useful > to keep. I staged all of these except: 11538453 New [4/8] db: cleanup attr_set_f and attr_remove_f 11538455 New [5/8] db: validate name and namelen in attr_set_f and attr_remove_f 11538457 New [6/8] db: ensure that create and replace are exclusive in attr_set_f because i'm not sure about patch 4/8; because the structure bits that need initialization differ a bit between set and remove, and because the initial backport missed a couple initializations, I feel like initializing the structure just before the libxfs call might be more obvious in terms of what's getting passed in. (however, if we keep that I should make the attr_filter variable work the same way) patches 5 and 6 just depend on the decision re: patch 4. thanks, -Eric
