On 5/9/20 12:10 PM, Christoph Hellwig wrote: > On Sat, May 09, 2020 at 10:07:12AM -0700, Darrick J. Wong wrote: >> On Sat, May 09, 2020 at 07:01:20PM +0200, Christoph Hellwig wrote: >>> Explain the bno field that is not actually part of the structure >>> anymore. >>> >>> Signed-off-by: Christoph Hellwig <hch@xxxxxx> >>> --- >>> db/agfl.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/db/agfl.c b/db/agfl.c >>> index 45e4d6f9..ce7a2548 100644 >>> --- a/db/agfl.c >>> +++ b/db/agfl.c >>> @@ -47,6 +47,7 @@ const field_t agfl_crc_flds[] = { >>> { "uuid", FLDT_UUID, OI(OFF(uuid)), C1, 0, TYP_NONE }, >>> { "lsn", FLDT_UINT64X, OI(OFF(lsn)), C1, 0, TYP_NONE }, >>> { "crc", FLDT_CRC, OI(OFF(crc)), C1, 0, TYP_NONE }, >>> + /* the bno array really is behind the actual structure */ >> >> Er... the bno array comes /after/ the actual structure, right? > > Yes. That's what I mean, but after seems to be less confusing. so: /* the bno array is after the actual structure */ right? I can just do that on merge.