libxfs has stopped validating these parameters internally, so do it in the xfs_db commands. Signed-off-by: Christoph Hellwig <hch@xxxxxx> --- db/attrset.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/db/attrset.c b/db/attrset.c index 0a464983..e3575271 100644 --- a/db/attrset.c +++ b/db/attrset.c @@ -130,7 +130,16 @@ attr_set_f( } args.name = (const unsigned char *)argv[optind]; + if (!args.name) { + dbprintf(_("invalid name\n")); + return 0; + } + args.namelen = strlen(argv[optind]); + if (args.namelen >= MAXNAMELEN) { + dbprintf(_("name too long\n")); + return 0; + } if (args.valuelen) { args.value = memalign(getpagesize(), args.valuelen); @@ -216,7 +225,16 @@ attr_remove_f( } args.name = (const unsigned char *)argv[optind]; + if (!args.name) { + dbprintf(_("invalid name\n")); + return 0; + } + args.namelen = strlen(argv[optind]); + if (args.namelen >= MAXNAMELEN) { + dbprintf(_("name too long\n")); + return 0; + } if (libxfs_iget(mp, NULL, iocur_top->ino, 0, &args.dp, &xfs_default_ifork_ops)) { -- 2.26.2