On 5/8/20 2:13 AM, Christoph Hellwig wrote:
> On Thu, May 07, 2020 at 10:38:33PM -0500, Eric Sandeen wrote:
>> Long ago, group & project quota were mutually exclusive, and so
>> when we turned on XFS_QMOPT_ENOSPC ("return ENOSPC if project quota
>> is exceeded") when project quota was enabled, we only needed to
>> disable it again for user quota.
>>
>> When group & project quota got separated, this got missed, and as a
>> result if project quota is enabled and group quota is exceeded, the
>> error code returned is incorrectly returned as ENOSPC not EDQUOT.
>>
>> Fix this by stripping XFS_QMOPT_ENOSPC out of flags for group
>> quota when we try to reserve the space.
>
> Looks weird, but given that it has historical precedence, and you fix
> all this mess up in the next patch:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Thanks. I could roll it all up into one patch if that's better, this
seemed half weird / half more-obvious....
-Eric
