On Thu, May 07, 2020 at 11:00:34PM -0500, Eric Sandeen wrote: > The only place we return -EDQUOT, and therefore need to make a decision > about returning -ENOSPC for project quota instead, is in xfs_trans_dqresv(). > > So there's no reason to be setting and clearing XFS_QMOPT_ENOSPC at higher > levels; if xfs_trans_dqresv has failed, test if the dqp we were were handed > is a project quota and if so, return -ENOSPC instead of EDQUOT. The > complexity is just a leftover from when project & group quota were mutually > exclusive and shared some codepaths. > > The prior patch was the trivial bugfix, this is the slightly more involved > cleanup. Nice: Reviewed-by: Christoph Hellwig <hch@xxxxxx>