On 5/7/20 7:17 AM, Christoph Hellwig wrote: > Hi Eric, > > as I've done a lot of API churn in 5.7 I though I'd volunteer resyncing > libxfs for this window. This series contains all the patches that > need to be ported over. Thanks Christoph - Ok - Darrick has done this as well, and I was just finishing regression testing on the net result of his and my work. (Darrick usually has this done first, and then I do an independent resync and we compare notes, as a weird backdoor form of review.) Obviously I'm being too slow at this. :( I appreciate the effort, though I guess we need a better strategy for speed and efficiency. I'll compare your patchset to Darrick's and to mine, between the 3 of us we should have a robust set of changes. > There are a few issues, though: > > - with "xfs: remove the di_version field from struct icdinode" > xfs_check fails after various tests with multiply claimed extents. > This seems like some weird race, as neither repair nor manually > running check finds anything. I had to patch out running xfs_check > to get useful xfstests runs > - but xfs/017 manually runs check and also still sees this > - xfs/122 will need an update for the xfs_agl changes, I can send > that > - xfs/307 and xfs/308 now print new messages due to the ported over > AGF verifier tightening > > For now I'm a little lost on the xfs check issues and would like to > share the work. Maybe someone has an idea, otherwise I need to keep > on digging more. >