On Fri, May 01, 2020 at 09:34:31AM -0400, Brian Foster wrote: > > + default: > > + xfs_inode_verifier_error(ip, -EFSCORRUPTED, __func__, dip, > > + sizeof(*dip), __this_address); > > + return -EFSCORRUPTED; > > + } > > Can we fix this function up to use an error variable and return error at > the end like xfs_iformat_attr_work() does? Otherwise nice cleanup.. What would the benefit of a local variable be here? It just adds a little extra code for no real gain.
