> diff --git a/fs/xfs/xfs_dquot_item_recover.c b/fs/xfs/xfs_dquot_item_recover.c > index 07ff943972a3..a07c1c8344d8 100644 > --- a/fs/xfs/xfs_dquot_item_recover.c > +++ b/fs/xfs/xfs_dquot_item_recover.c > @@ -197,4 +197,5 @@ xlog_recover_quotaoff_commit_pass1( > const struct xlog_recover_item_ops xlog_quotaoff_item_ops = { > .item_type = XFS_LI_QUOTAOFF, > .commit_pass1 = xlog_recover_quotaoff_commit_pass1, > + .commit_pass2 = NULL, /* nothing to do in pass2 */ No need to initialize 0 or NULL fields in static structures. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>