On Mon, May 04, 2020 at 06:11:03PM -0700, Darrick J. Wong wrote: > + if (item->ri_ops && item->ri_ops->commit_pass2) > + return item->ri_ops->commit_pass2(log, buffer_list, item, > + trans->r_lsn); > + I don't think ri_ops can ever be NULL here, so the check should be removed. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>