Re: [PATCH v3 13/17] xfs: combine xfs_trans_ail_[remove|delete]()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 01, 2020 at 01:00:31AM -0700, Christoph Hellwig wrote:
> On Wed, Apr 29, 2020 at 01:21:49PM -0400, Brian Foster wrote:
> >  /**
> > - * Remove a log items from the AIL
> > + * Remove a log item from the AIL.
> >   *
> > + * For each log item to be removed, unlink it from the AIL, clear the IN_AIL
> 
> This only works on one item, so the "For each" seems wrong.   That being
> said I think we can just remove the comment entirely - the 'remove a log
> item from the AIL' is pretty obvious from the name, and the details are
> described in the helper actually implementing the functionality.
> 

Works for me, comment removed.

Brian

> The rest looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux