On Thu, Apr 30, 2020 at 11:58:41AM -0700, Darrick J. Wong wrote: > On Wed, Apr 29, 2020 at 01:21:49PM -0400, Brian Foster wrote: > > Now that the functions and callers of > > xfs_trans_ail_[remove|delete]() have been fixed up appropriately, > > the only difference between the two is the shutdown behavior. There > > are only a few callers of the _remove() variant, so make the > > shutdown conditional on the parameter and combine the two functions. > > > > Suggested-by: Dave Chinner <david@xxxxxxxxxxxxx> > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> > > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> > > Ok. I guess the rest of you like this broken out though tbh I found it > harder to figure out why and where we were going (and used git range > diff as a crutch). Not that I'm asking to have things put back. I got > through it already... :) The fine grained split actually allowed me to understand what was going on. The large catch all patch looks vaguely nice to me, but I could not really reason how it was correct, this series nicely leads there.
