On Tue, Apr 28, 2020 at 03:34:22PM -0700, Darrick J. Wong wrote: > > I find both the runtime logging and recovery code to be complex enough > > individually that I prefer not to stuff them together, but there is > > already precedent with dfops and such so that's not the biggest deal to > > me if the interface is simplified (and hopefully amount of code > > reduced). > > I combined them largely on the observation that with the exception of > buffers, log item recovery code is generally short and not worth > creating even more files. 224 is enough. True, the buffer items are a fair amount of code, also called into from say the inode buffers. Maybe we need a new xfs_buf_item_recovery.c file in that case?
