On Sat, Apr 25, 2020 at 11:28:01AM -0700, Christoph Hellwig wrote: > On Tue, Apr 21, 2020 at 07:07:13PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Move the extent free intent and intent-done log recovery code into the > > per-item source code files and use dispatch functions to call them. We > > do these one at a time because there's a lot of code to move. No > > functional changes. > > What is the reason for splitting xlog_recover_item_type vs > xlog_recover_intent_type? To me it would seem more logical to have > one operation vector, with some ops only set for intents. Partly because I started by refactoring only the intent items, and then decided to prepend a series to do everything; and partly to be stingy with bytes. :P That said, I like your suggestion of every XFS_LI_* code gets its own xlog_recover_item_type so I'll go do that. --D
