On Sat, Apr 25, 2020 at 11:36:44AM -0700, Christoph Hellwig wrote: > On Tue, Apr 21, 2020 at 07:08:05PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Move xlog_recover_intent_pass2 up in the file so that we don't have to > > have a forward declaration of a static function. > > FYI, I'd expect IS_INTENT and IS_INTENT_DONE to simply be flags in the > xlog_recover_item_type structure. If I simply gave every XFS_LI_* type code its own xlog_recover_item_type, there wouldn't even be a need for that. Though I dunno, an entire xlog_recover_item_type for each of the done item types might be a lot of NULL space. <shrug> Maybe I'm stressing out too much over 8 * 6 pointers == 400 bytes. --D
