On Mon, Apr 27, 2020 at 10:11:54PM -0700, Christoph Hellwig wrote: > On Mon, Apr 27, 2020 at 03:04:12PM -0700, Darrick J. Wong wrote: > > > > + case XFS_LI_INODE: > > > > + return &xlog_inode_item_type; > > > > + case XFS_LI_DQUOT: > > > > + return &xlog_dquot_item_type; > > > > + case XFS_LI_QUOTAOFF: > > > > + return &xlog_quotaoff_item_type; > > > > + case XFS_LI_IUNLINK: > > > > + /* Not implemented? */ > > > > > > Not implemented! I think we need a prep patch to remove this first. > > > > The thing I can't tell is if XFS_LI_IUNLINK is a code point reserved > > from some long-ago log item that fell out, or reserved for some future > > project? > > > > Either way, this case doesn't need to be there. > > The addition goes back to: > > commit 1588194c4a13b36badf2f55c022fc4487633f746 > Author: Adam Sweeney <ajs@xxxxxxx> > Date: Fri Feb 25 02:02:01 1994 +0000 > > Add new prototypes and log item types. > > > In the imported tree, which only added the definition, and no code > related to it. I can't find any code related to it either in random > checkpoints. <nod> Dave told me on IRC that it was added in 1994 but never used, so it's safe to get rid of it entirely. --D
