On Sat, Apr 25, 2020 at 10:37:17AM -0700, Christoph Hellwig wrote: > On Wed, Apr 22, 2020 at 01:54:25PM -0400, Brian Foster wrote: > > Make the following changes to clean up both of these functions: > > > > - Most callers of xfs_trans_ail_delete() acquire the AIL lock just > > before the call. Update _delete() to acquire the lock and open > > code the couple of callers that make additional checks under AIL > > lock. > > - Drop the unnecessary ailp parameter from _delete(). > > - Drop the unused shutdown parameter from _remove() and open code > > the implementation. > > > > In summary, this leaves a _delete() variant that expects an AIL > > resident item and a _remove() helper that checks the AIL bit. Audit > > the existing callsites for use of the appropriate function and > > update as necessary. > > Wouldn't it make sense to split this into separate patches for the > items above? I have a bit of a hard time verifying this patch, even > if the goal sounds just right. > This ended up as one patch pretty much because I couldn't figure out what the factoring steps needed to be until I came to the end result. I'll revisit splitting it up.. Brian
