From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Move the log quotaoff item pass2 commit code into the per-item source code files and use the dispatch function to call it. We do these one at a time because there's a lot of code to move. No functional changes. Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --- fs/xfs/xfs_log_recover.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index 18b797ca4a6c..5e7e5c66327e 100644 --- a/fs/xfs/xfs_log_recover.c +++ b/fs/xfs/xfs_log_recover.c @@ -2502,20 +2502,16 @@ xlog_recover_commit_pass2( { trace_xfs_log_recover_item_recover(log, trans, item, XLOG_RECOVER_PASS2); - if (item->ri_type && item->ri_type->commit_pass2_fn) - return item->ri_type->commit_pass2_fn(log, buffer_list, item, - trans->r_lsn); - - switch (ITEM_TYPE(item)) { - case XFS_LI_QUOTAOFF: - /* nothing to do in pass2 */ - return 0; - default: + if (!item->ri_type) { xfs_warn(log->l_mp, "%s: invalid item type (%d)", __func__, ITEM_TYPE(item)); ASSERT(0); return -EFSCORRUPTED; } + if (!item->ri_type->commit_pass2_fn) + return 0; + return item->ri_type->commit_pass2_fn(log, buffer_list, item, + trans->r_lsn); } STATIC int