On Mon, Apr 20, 2020 at 02:37:17PM +1000, Dave Chinner wrote: > On Fri, Apr 17, 2020 at 11:08:59AM -0400, Brian Foster wrote: > > Introduce an error tag to randomly fail async buffer writes. This is > > primarily to facilitate testing of the XFS error configuration > > mechanism. > > > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> > > Isn't this what XFS_ERRTAG_IODONE_IOERR and XFS_RANDOM_IODONE_IOERR > is for? > That one triggers log I/O errors, which is an imminent shutdown error scenario. I'm not aware of a clean way to combine the two, though the above could probably use a better name. TBH, I wasn't sure about the name for the buffer one either. I wonder if XFS_ERRTAG_LOG_IOERROR and XFS_ERRTAG_METADATA_IOERROR would be more usable..? That's assuming we're Ok with changing existing error tag names. The IODONE one appears to have been around forever... Brian > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx >
