On Mon, Apr 20, 2020 at 01:58:58PM +1000, Dave Chinner wrote: > On Fri, Apr 17, 2020 at 11:08:55AM -0400, Brian Foster wrote: > > The quotaoff intent item push handler unconditionally returns locked > > status because it remains AIL resident until removed by the > > quotafoff end intent. xfsaild_push_item() already returns pinned > > status for items (generally intents) without a push handler. This is > > effectively the same behavior for the purpose of quotaoff, so remove > > It's not the same. XFS_ITEM_PINNED results in a log force from the > xfsaild, while XFS_ITEM_LOCKED items are just skipped. So this > change will result in a log force every time the AIL push sees a > quotaoff log item. Hence I think the code as it stands is correct > as log forces will not speed up the removal of the quotaoff item > from the AIL... > Ah right.. I was thinking we had a count heuristic there but we potentially force the log once we hit at least one pinned item. I think this same thing might have come up when this was first refactored. I'll drop this one.. Brian > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx >
