On Thu, Apr 09, 2020 at 10:08:56AM +0200, Arnd Bergmann wrote: > I ran into a linker warning in XFS that originates from a mismatch > between libelf, binutils and objtool when certain files in the kernel > are built with "gcc -g": > > x86_64-linux-ld: fs/xfs/xfs_trace.o: unable to initialize decompress status for section .debug_info > > After some discussion, nobody could identify why xfs sets this flag > here. CONFIG_XFS_DEBUG used to enable lots of unrelated settings, but > now its main purpose is to enable extra consistency checks and assertions > that are unrelated to the debug info. > > Remove the Makefile logic to set the flag here. If anyone relies > on the debug info, this can simply be enabled again with the global > CONFIG_DEBUG_INFO option. > > Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx> > Link: https://lore.kernel.org/lkml/20200409074130.GD21033@xxxxxxxxxxxxx/ > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- Seems reasonable. Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx> > fs/xfs/Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile > index 4f95df476181..ff94fb90a2ee 100644 > --- a/fs/xfs/Makefile > +++ b/fs/xfs/Makefile > @@ -7,8 +7,6 @@ > ccflags-y += -I $(srctree)/$(src) # needed for trace events > ccflags-y += -I $(srctree)/$(src)/libxfs > > -ccflags-$(CONFIG_XFS_DEBUG) += -g > - > obj-$(CONFIG_XFS_FS) += xfs.o > > # this one should be compiled first, as the tracing macros can easily blow up > -- > 2.26.0 >
