On 4/6/20 1:52 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> xfs_da_read_buf dropped the 'mappedbno' argument in favor of a flags
> argument. Foolishly, we're passing that parameter (which is -1 in all
> callers) to xfs_da_read_buf, which gets us the wrong behavior.
>
> Since mappedbno == -1 meant "complain if we fall into a hole" (which is
> the default behavior of xfs_da_read_buf) we can fix this by passing a
> zero flags argument and getting rid of mappedbno entirely.
>
> Coverity-id: 1457898
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
Looks good; I think this patch
Fixes: 5f356ae6d ("xfs: remove the mappedbno argument to xfs_da_read_buf")
(i.e. the merge of that kernel commit, which I biffed on, apparently)
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
