[RFC 0/2] Begin switching iomap from apply to iter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>

I don't like the 'apply' design pattern.  It splits the logic between
two functions, and from a performance point of view, it introduces an
indirect function call which is more expensive due to Spectre.  This rfc
only converts one function over to use the new API as a demonstration.
I don't want to waste time on it if people aren't interested in this
approach.

I haven't tested this at all; it's probably buggy.

Matthew Wilcox (Oracle) (2):
  iomap: Add iomap_iter API
  iomap: Convert page_mkwrite to iter API

 fs/iomap/Makefile      |  2 +-
 fs/iomap/buffered-io.c | 51 ++++++++++----------------
 fs/iomap/iter.c        | 81 ++++++++++++++++++++++++++++++++++++++++++
 include/linux/iomap.h  | 24 +++++++++++++
 4 files changed, 125 insertions(+), 33 deletions(-)
 create mode 100644 fs/iomap/iter.c

-- 
2.25.1




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux