On Tue, Mar 24, 2020 at 02:01:46PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > When quotacheck runs, it zeroes all the timer fields in every dquot. > Unfortunately, it also does this to the root dquot, which erases any > preconfigured grace intervals and warning limits that the administrator > may have set. Worse yet, the incore copies of those variables remain > set. This cache coherence problem manifests itself as the grace > interval mysteriously being reset back to the defaults at the /next/ > mount. > > Fix it by not resetting the root disk dquot's timer and warning fields. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Looks good, although a comment in the code about the special nature of qid 0 might be useful. Otherwise: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
