On Tue, Mar 24, 2020 at 01:47:58PM -0700, Darrick J. Wong wrote: > On Tue, Mar 24, 2020 at 11:19:28AM +1100, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Many operations don't set the exitcode when they fail, resulting > > in xfs_io exiting with a zero (no failure) exit code despite the > > command failing and returning an error. The command return code is > > really a boolean to tell the libxcmd command loop whether to > > continue processing or not, while exitcode is the actual xfs_io exit > > code returned to the parent on exit. > > > > This patchset just makes the code do the right thing. It's not the > > nicest code, but it's a start at producing correct behaviour. > > > > Signed-Off-By: Dave Chinner <dchinner@xxxxxxxxxx> > > Looks fine to me, but we're also going to need to audit db, quota, and > spaceman too, right? Most likely, but I haven't looked that far - this was more a reaction to people noting that xfs_io doesn't do the right thing so exit code could not be relied on in fstests... The others? Not so critical, I think. But I'll have a look... > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Thanks! -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
