On Tue, Mar 24, 2020 at 11:19:24AM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Move the checks for zero block/sector size to the libfrog code > and return -1LL as an invalid value instead. Catch the invalid > value in mkfs and error out there instead of inside cvtnum. > > Also rename the libfrog block/sector size variables so they don't > shadow the mkfs global variables of the same name and mark the > string being passed in as a const. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> I'd have split this into one patch for the cvtnum cleanups, and one for the mkfs conversion. But otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
