On Mon, Mar 16, 2020 at 02:25:39PM -0700, Darrick J. Wong wrote: > > * At this point, we're umounting anyway, so there's no point in > > - * transitioning log state to IOERROR. Just continue... > > + * transitioning log state to IO_ERROR. Just continue... > > "...so there's no point in marking the log as shut down."? > > There's no IOERROR state anymore, right? There is on the log itself: log->l_flags |= XLOG_IO_ERROR; but I think your version is nicer anyway.