On Mon, Mar 16, 2020 at 03:41:06AM -0700, Christoph Hellwig wrote: > > diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile > > index 135f4478aa5a..3b0b21a4dcde 100644 > > --- a/fs/xfs/Makefile > > +++ b/fs/xfs/Makefile > > @@ -41,6 +41,7 @@ xfs-y += $(addprefix libxfs/, \ > > xfs_bmap.o \ > > xfs_bmap_btree.o \ > > xfs_btree.o \ > > + xfs_btree_staging.o \ > > We only needs this for online repair don't we? Can we exclude the > file from the build for xfs configs without scrub/repair? That could be done, provided we don't mind having #ifdef CONFIG_XFS_ONLINE_REPAIR checks in the parts of libxfs that call xfs_btree_commit_afakeroot and xfs_btree_stage_*fakeroot. After which we'll have to work around that in xfsprogs when I (re)send my series to refactor all the open-coded btree creation code out of xfs_repair. Not a big deal if others want to save ~9k of space (debug mode is on): text data bss dec hex filename 8767 313 0 9080 2378 fs/xfs/libxfs/xfs_btree_staging.o --D
