Re: [PATCH] xfs: xfs_dabuf_map should return ENOMEM when map allocation fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I've verified the commit "45feef8f50b94d56d6a433ad5baf5cdf58e3db98",
which was adds goto statement and it make sense to set error to
-ENOMEM when kmem_zalloc() fails.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>

On 03/14/2020 06:44 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong<darrick.wong@xxxxxxxxxx>
>
> If the xfs_buf_map array allocation in xfs_dabuf_map fails for whatever
> reason, we bail out with error code zero.  This will confuse callers, so
> make sure that we return ENOMEM.  Allocation failure should never happen
> with the small size of the array, but code defensively anyway.
>
> Fixes: 45feef8f50b94d ("xfs: refactor xfs_dabuf_map")
> Signed-off-by: Darrick J. Wong<darrick.wong@xxxxxxxxxx>
> ---





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux