On Wed, Mar 11, 2020 at 09:28:56AM +1100, Dave Chinner wrote: > On Mon, Mar 09, 2020 at 09:02:52AM +0100, Christoph Hellwig wrote: > > On Fri, Mar 06, 2020 at 11:09:17AM -0500, Brian Foster wrote: > > > On Fri, Mar 06, 2020 at 07:31:31AM -0700, Christoph Hellwig wrote: > > > > Remove the ignored return value from xfs_log_unmount_write, and also > > > > remove a rather pointless assert on the return value from xfs_log_force. > > > > > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > --- > > > > > > I guess there's going to be obvious conflicts with Dave's series and > > > some of these changes. I'm just going to ignore that and you guys can > > > figure it out. :) > > > > I'm glad to rebase this on top of the parts of his series that I think > > make sense. Just wanted to send this out for now to show what I have > > in mind in this area. > > FWIW, I'm typing limited at the moment because of a finger injury. > > I was planning to rebase mine on the first 6 patches of this series > (i.e. all but the IOERROR removal patch) a couple of days ago, but > I'm really slow at getting stuff done at the moment. So if Darrick > is happy with this patchset, don't let my cleanup hold it up. Ahh, I'd held back to see what would develop. :) I'll have a look then. --D > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx