On Wed, Mar 04, 2020 at 06:53:59PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > The unmount iclog handling is duplicated in both > xfs_log_unmount_write() and xfs_log_write_unmount_record(). We only > need one copy of it in xfs_log_unmount_write() because that is the > only function that calls xfs_log_write_unmount_record(). The copy in xfs_log_unmount_write actually is dead code. It only is called in the XLOG_FORCED_SHUTDOWN case, in which case all iclogs are marked as STATE_IOERROR, and thus xlog_state_release_iclog is a no-op. I really need to send the series out to clean this up ASAP..
