On Wed, Mar 04, 2020 at 06:53:55PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Separate out the unmount record writing from the rest of the > ticket and log state futzing necessary to make it work. This is > a no-op, just makes the code cleaner and places the unmount record > formatting and writing alongside the commit record formatting and > writing code. > > We can also get rid of the ticket flag clearing before the > xlog_write() call because it no longer cares about the state of > XLOG_TIC_INITED. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>