On Wed, Mar 04, 2020 at 09:26:43AM +1100, Dave Chinner wrote:
> On Fri, Feb 28, 2020 at 05:49:15PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> >
> > In xchk_xattr_listent, we attempt to validate the extended attribute
> > hash structures by performing a attr lookup by (hashed) name. If the
> > lookup returns ENODATA, that means that the hash information is corrupt.
> > The _process_error functions don't catch this, so we have to add that
> > explicitly.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > ---
> > fs/xfs/scrub/attr.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> >
> > diff --git a/fs/xfs/scrub/attr.c b/fs/xfs/scrub/attr.c
> > index d9f0dd444b80..54ea1efa7ddc 100644
> > --- a/fs/xfs/scrub/attr.c
> > +++ b/fs/xfs/scrub/attr.c
> > @@ -163,6 +163,11 @@ xchk_xattr_listent(
> > args.valuelen = valuelen;
> >
> > error = xfs_attr_get_ilocked(context->dp, &args);
> > + if (error == -ENODATA) {
> > + /* ENODATA means the hash lookup failed and the attr is bad */
> > + xchk_fblock_set_corrupt(sx->sc, XFS_ATTR_FORK, args.blkno);
> > + goto fail_xref;
> > + }
> > if (!xchk_fblock_process_error(sx->sc, XFS_ATTR_FORK, args.blkno,
> > &error))
> > goto fail_xref;
>
> Same question as the first patch.
Same resolution as the first patch. :)
--D
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@xxxxxxxxxxxxx
