On Mon, Mar 02, 2020 at 12:00:52AM +0800, Eryu Guan wrote: > On Tue, Feb 04, 2020 at 04:02:23PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Add new helpers to dmerror to provide for marking selected ranges > > totally bad -- both reads and writes will fail. Create a new test for > > xfs_scrub to check that it reports media errors correctly. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > So is this expected to fail with latest xfsprogs for-next branch? I got > failures like: > > QA output created by 515 > Scrub for injected media error > -Corruption: disk offset NNN: media error in inodes. (!) > -SCRATCH_MNT: Unmount and run xfs_repair. The test should pass ... and I can't reproduce it all here. What are you MKFS_OPTIONS and MOUNT_OPTIONS and kernel? Here's mine: --D FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 magnolia-mtr00 5.6.0-rc4-xfsx #rc4 SMP PREEMPT Mon Mar 2 21:02:17 PST 2020 MKFS_OPTIONS -- -f -m reflink=1,rmapbt=1, -i sparse=1, /dev/sdf MOUNT_OPTIONS -- -o usrquota,grpquota,prjquota, /dev/sdf /opt xfs/747 3s Ran: xfs/747 Passed all 1 tests ------------------- FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 magnolia-mtr00 5.6.0-rc4-xfsx #rc4 SMP PREEMPT Mon Mar 2 21:02:17 PST 2020 MKFS_OPTIONS -- -f -m crc=0,reflink=0,rmapbt=0, -i sparse=0, /dev/sdf MOUNT_OPTIONS -- -o usrquota,grpquota, /dev/sdf /opt xfs/747 [not run] crc feature not supported by this filesystem Ran: xfs/747 Not run: xfs/747 Passed all 1 tests ------------------- FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 magnolia-mtr00 5.6.0-rc4-xfsx #rc4 SMP PREEMPT Mon Mar 2 21:02:17 PST 2020 MKFS_OPTIONS -- -f -m reflink=1,rmapbt=0, -i sparse=1, /dev/sdf MOUNT_OPTIONS -- -o usrquota,grpquota,prjquota, /dev/sdf /opt xfs/747 2s Ran: xfs/747 Passed all 1 tests -------------------- FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 magnolia-mtr00 5.6.0-rc4-xfsx #rc4 SMP PREEMPT Mon Mar 2 21:02:17 PST 2020 MKFS_OPTIONS -- -f -m reflink=0,rmapbt=0, -i sparse=1, /dev/sdf MOUNT_OPTIONS -- -o usrquota,grpquota,prjquota, /dev/sdf /opt xfs/747 3s Ran: xfs/747 Passed all 1 tests --D