On 3/3/20 7:48 AM, Darrick J. Wong wrote: > On Mon, Mar 02, 2020 at 09:03:37PM -0600, Eric Sandeen wrote: >> On 2/18/20 8:55 PM, Eric Sandeen wrote: >>> On 12/31/19 7:11 PM, Darrick J. Wong wrote: >>>> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >>>> >>>> When quotacheck runs, it zeroes all the timer fields in every dquot. >>>> Unfortunately, it also does this to the root dquot, which erases any >>>> preconfigured grace interval that the administrator may have set. Worse >>>> yet, the incore copies of those variables remain set. This cache >>>> coherence problem manifests itself as the grace interval mysteriously >>>> being reset back to the defaults at the /next/ mount. >>>> >>>> Fix it by resetting the root disk dquot's timer fields to the incore >>>> values. >>> >>> Uh, so, even with this, it seems that we don't properly set up default time >>> limits on the first mount. Looking into it... >> >> Sorry. This was actually a regression from my timer-per-type series. :( >> >> so ignore this critique, it's my fault. ;) > > But will you (or anyone really) please review this fix? I did; I have other comments on it up-thread. -Eric
