On Wed, Feb 26, 2020 at 12:23:06PM -0800, Christoph Hellwig wrote: > Let the low-level attr code only allocate the needed buffer size > for xfs_attrmulti_attr_get instead of allocating the upper bound > at the top of the call chain. > > Suggested-by: Dave Chinner <dchinner@xxxxxxxxxx> > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > --- > fs/xfs/xfs_ioctl.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c > index c805fdf4ea39..47a92400929b 100644 > --- a/fs/xfs/xfs_ioctl.c > +++ b/fs/xfs/xfs_ioctl.c > @@ -481,10 +481,6 @@ xfs_attrmulti_attr_get( > if (*len > XFS_XATTR_SIZE_MAX) > return -EINVAL; > > - args.value = kmem_zalloc_large(*len, 0); > - if (!args.value) > - return -ENOMEM; > - > error = xfs_attr_get(&args); > if (error) > goto out_kfree; > -- > 2.24.1 >
