On 2/26/20 9:24 AM, Darrick J. Wong wrote: > On Wed, Feb 26, 2020 at 09:09:42AM -0800, Eric Sandeen wrote: ... >> I guess I should stop saying "I'll do that on the way in" if 2 more >> versions are going to hit the list, maybe it takes the feedback off >> your radar. > > I (almost) always make the changes to my local tree even if you say > you'll do it on the way in, because that makes it easier to compare the > for-next tree vs. my about-to-be-rebased dev tree. > > Unfortunately, I do occasionally slip up and forget to make the changes, > even if I've sent email assenting to the changes, because there's not > anything linking "I will make this change" in the email thread to > actually scribbling in the git tree. > > Add to that the fact that email clients don't maintain spatial locality > between v3->v4->v5 of a patchset and that just makes it more difficult > to stay on top of reviews as a developer, because I can't even > self-check without having to scroll through hundreds of emails. > > So yeah, I guess I'll go review my reviews... sorry for the crap. No problem. We're all in this together. ;) Thanks, -Eric > --D
