On Tue, Feb 25, 2020 at 03:09:47PM -0800, Christoph Hellwig wrote: > Simplify the user copy code by using strndup_user. This means that we > now do one memory allocation per operation instead of one per ioctl, > but memory allocations are cheap compared to the actual file system > operations. Also the error for an invalid path is now EINVAL or EFAULT > instead of the previous odd and undocumented ERANGE. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Chandan Rajendra <chandanrlinux@xxxxxxxxx> > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > fs/xfs/xfs_ioctl.c | 17 +++++------------ > fs/xfs/xfs_ioctl32.c | 17 +++++------------ > 2 files changed, 10 insertions(+), 24 deletions(-) Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
